-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent channel deletion when unsetting device channel #1012
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
Co-Authored-By: Martin DONADIEU <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
method, | ||
headers: { | ||
'Content-Type': 'application/json', | ||
'Authorization': `Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJzdXBhYmFzZS1kZW1vIiwicm9sZSI6ImFub24iLCJleHAiOjE5ODM4MTI5OTZ9.CRXP1A7WOeoJeXxjNni43kdQwgnWNReilDMblYTn_I0`, |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
authorization header
Co-Authored-By: Martin DONADIEU <[email protected]>
@@ -204,6 +204,7 @@ | |||
"husky": "^9.1.7", | |||
"miniflare": "^3.20250124.0", | |||
"sass": "1.83.4", | |||
"supabase": "1.127.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do no add this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not modify this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do no rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain your changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain your changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice to have new test
Devin is currently unreachable - the session may have died. |
4 similar comments
Devin is currently unreachable - the session may have died. |
Devin is currently unreachable - the session may have died. |
Devin is currently unreachable - the session may have died. |
Devin is currently unreachable - the session may have died. |
This PR fixes an issue where setting and unsetting channels could lead to channel deletion.
Changes:
Link to Devin run: https://app.devin.ai/sessions/bc29fbacdbff4090907fd1dcd13afc3c
Requested by: Martin